View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0026150 | mantisbt | bugtracker | public | 2019-09-17 06:17 | 2020-01-07 03:37 |
Reporter | dregad | Assigned To | vboctor | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 2.23.0 | ||||
Target Version | 2.23.0 | Fixed in Version | 2.23.0 | ||
Summary | 0026150: Closing issues via group action with empty note creates a bugnote record | ||||
Description | This regression was initially reported by @syncguru in ~0062828, following @atrol's closing of several issues. List of affected issues (from the 16.09.2019 update): 0007584, 0007642, 0020789, 0022822, 0025237, 0026105, 0026107, 0026111, #26112, 0026115. These were identified by looking at Timeline, a more thorough check should be performed against the database | ||||
Steps To Reproduce |
Look at the closed issue and notice that a new, empty bugnote was created | ||||
Additional Information | According to git bisect, MantisBT master 13d0f15d is the first bad commit | ||||
Tags | No tags attached. | ||||
@vboctor this is caused by no longer aborting bugnote_add() if bugnote_text is empty [1]. I'm not sure why this change was necessary in the context of fixing 0009802 (Support private attachments with empty note) - from my perspective, private or not a bugnote should only be created if it has content. |
|
Cleaned up the notes |
|
Assigned to vboctor as discussed on Gitter |
|
MantisBT: master 13d0f15d 2019-08-03 13:51 Details Diff |
Support private attachments with empty note |
Affected Issues 0009802, 0026150 |
|
mod - bugnote_add.php | Diff File | ||
mod - bugnote_view_inc.php | Diff File | ||
mod - core/bugnote_api.php | Diff File | ||
MantisBT: issue26150_blank_note_group_close 3eaf5cca 2019-12-05 21:11 Details Diff |
Avoid blank notes on group resolve/close actions Fixes 0026150 Signed-off-by: Victor Boctor <victor@mantishub.net> |
Affected Issues 0026150 |
|
mod - core/bug_api.php | Diff File | ||
MantisBT: master 89b5f4c5 2019-12-05 21:11 Details Diff |
Avoid blank notes on group resolve/close actions Fixes 0026150 Signed-off-by: Victor Boctor <victor@mantishub.net> |
Affected Issues 0026150 |
|
mod - core/bug_api.php | Diff File |